search

jliljebl / flowblade

Video Editor for Linux
GNU General Public License v3.0
2.66k stars 181 forks source link

GTK themes in Flowblade #955

Closed smolnp closed 3 years ago

smolnp commented 3 years ago

When choosing a dark theme, if any light theme (except Arc) is installed on the system, the Flowblade will be decorated in light colors and vice versa. With the Arc theme, everything works as expected. Example: Mint-Y mintgrey Now choose Mint-Y-Dark mitdarc Flowblade will be dark even if the Arc light theme is selected arctheme Is this the correct behavior?

smolnp commented 3 years ago

Also, I think the neutral theme is more gray than gray. Maybe the names are confused? grey neytral

jliljebl commented 3 years ago

When choosing a dark theme, if any light theme (except Arc) is installed on the system, the Flowblade will be decorated in light colors and vice versa. With the Arc theme, everything works as expected.

"Adwaita" works too. The issue here that I have this line of code:

 Gtk.Settings.get_default().set_property("gtk-application-prefer-dark-theme", True)

to set the decoration color and GTK theme has to support this feature for this to work. "Arc" and "Adwaita" support this, many others don't. GTK CSS does not give me access to this property unless I use the GtkHeaderBar but that is designed to hold widgets and is much too high for Flowblade which wants the traditional "small titlebar with application menu" UX.

Also, I think the neutral theme is more gray than gray. Maybe the names are confused?

Neutral means that all RGB values are exactly the same on all tones (e.g. 55,55,55) where as "Grey" has lightly bluish tint but is still grey in my view, not "Blue" like the current theme. I'll be probably making the "Neutral" the default theme from now as Final Cut X and Premier have both neutral themes and that seems to be the convention now.

I'm closing this with some label because right now there isn't anything I think I can do about these.