In OpenJDK, I proposed to change the code to use .seg, which is consistent with other similar invocations in Kernel32, and should ensure a pointer is sent to the native function:
https://github.com/openjdk/jdk/pull/20182
The patch herein is basically the same as the OpenJDK patch.
(I am not aware of a way to automatically test this.)
gnodet
commented
1 month ago
As described in OpenJDK bug: https://bugs.openjdk.org/browse/JDK-8336375
the invocation of
ScrollConsoleScreenBufferWin the FFM implementation ofKernel32may crash. I believe the reason is that the lookup/"declared" parameters are pointers: https://github.com/jline/jline3/blob/9489e1b15bd1ee9dd87393aeec7fc5489fbc8a09/terminal-ffm/src/main/java/org/jline/terminal/impl/ffm/Kernel32.java#L406 but the provided/actual invocation parameters are values: https://github.com/jline/jline3/blob/9489e1b15bd1ee9dd87393aeec7fc5489fbc8a09/terminal-ffm/src/main/java/org/jline/terminal/impl/ffm/Kernel32.java#L239In OpenJDK, I proposed to change the code to use
.seg, which is consistent with other similar invocations inKernel32, and should ensure a pointer is sent to the native function: https://github.com/openjdk/jdk/pull/20182The patch herein is basically the same as the OpenJDK patch.
(I am not aware of a way to automatically test this.)