Drop fusesource jansi - Githubissues

jline / jline3

JLine is a Java library for handling console input.

Other

1.49k stars 217 forks source link

Drop fusesource jansi #1056

Closed cstamas closed 1 month ago

cstamas commented 2 months ago

Replace everything in JLine with jansi-core own module. Also, some fixes made, as interpolation did not happen, etc.

Changes:

Dependency on org.fusesource:jansi is dropped. The project should go into oblivion.
Changed JLine classes to use "our" JAnsi
jansi-core (and jansi bundle) made "drop in replacement"

gnodet commented 2 months ago

I did not really want to keep the same package name, as I'm not 100% sure it can actually be used as a drop-in replacement. The dependencies and setup are quite different.

cstamas commented 2 months ago

So should I drop the org/fusesource classes then? Is the rest of change (drop of Jansi) ok?

gnodet commented 2 months ago

So should I drop the org/fusesource classes then?

I'd rather keep the package rename.

Is the rest of change (drop of Jansi) ok?

Imho they are consistent with the fact that I did not renamed the package. The jansi provider is using the "old jansi". The "new jansi" is built on top of jline, so we can't use it as a provider, it would not make sense. I plan to deprecate the "jansi" and "jna" providers soon, as "jni" and "ffm" are the ones that should be used.