Wishlist for testfiles - Githubissues

dinyar commented 9 years ago

Hi Joschka,

here a preliminary wishlist for the testbench pattern file. The current format (found in https://github.com/jlingema/uGMTScripts/tree/master/ugmt_patterns/data/patterns/emu) is more or less what the testbench accepts now, but the following additions/changes would be great:

Introduction of "track addresses". At the moment these would consist of eta, phi, and quality for three muons in a single line. The testbench expects XTRK eta1 phi1 qual1 eta2 phi2 qual2 eta3 phi3 qual3 where XTRK can be BTRK, OTRK+, FTRK+, OTRK-, and FTRK-.
Add fields for sort rank and empty bit at the end. The empty bit could be calculated in the tb, but it would be nice to test whether an "empty" muon (i.e. one with pT=0) which has values for eta and phi makes problems. (Currently this would trigger dinyar/uGMTfirmware#23)
Fill all muons if possible. Currently if a muon is empty it is not represented in the pattern file. I'm currently assigning muons to their bin in the input vector by position so it would be easiest if null muons were represented by a line of zeros.

Let me know if something can't be changed easily, it may be a fast fix in the testbench..

jlingema commented 9 years ago

Is position of XTRK important? I.e. before / after muons (before / after energies)?

dinyar commented 9 years ago

No, i only use the "internal ordering", so muons should be ordered from fwd+ to fwd- and tracks as well, but they could be interlaced.

On Wed, Nov 5, 2014, 13:19 Joschka Lingemann notifications@github.com wrote:

Is position of XTRK important? I.e. before / after muons (before / after energies)?

— Reply to this email directly or view it on GitHub https://github.com/jlingema/uGMTScripts/issues/9#issuecomment-61799036.

jlingema commented 9 years ago

A first version of this has been added to the repo: https://github.com/jlingema/uGMTScripts/tree/master/ugmt_patterns/data/patterns/testbench

Please check and let me know if something should be changed.

dinyar commented 9 years ago

This is working well with the first version of the testbench. Would it be possible though to remove the two newlines at the end of the pattern files?

jlingema commented 9 years ago

The new version does not have newlines anymore.

dinyar commented 9 years ago

Great, seems to work now! Closing.

dinyar commented 9 years ago

fyi: I just checked - at least one newline doesn't seem to crash the testbench.

jlingema / uGMTScripts

Wishlist for testfiles #9