[idea] Replace BigBuf - Githubissues

jlitewski / proxmark3

NXTGEN Development fork - Proxmark3

GNU General Public License v3.0

0 stars 0 forks source link

[idea] Replace BigBuf #3

Open jlitewski opened 6 months ago

jlitewski commented 6 months ago

Core Changes:

[x] Implement a true memory manager (palloc)
[x] Remove the tracing functions from BigBuf and implement them in their own file (tracer)
[x] Remove the card emulation functions from BigBuf and implement them in their own file (cardemu)

Major Milestones:

[x] Replace BigBuf with palloc (for memory management)
[x] Replace BigBuf with tracer (for tracing things)
[x] Replace BigBuf with cardemu (for card emulation)
[ ] Modify the client to correctly handle all the new PM3_EMALLOC returns
[ ] Write test suites for all the new code to verify functionality

Minor Milestones:

[x] Merge nxtgen-palloc into proxmark3-nxtgen
[ ] Remove BigBuf from the firmware
[ ] Optimize global/static variable sizes to get back some SRAM
[ ] Optimize functions to use correctly sized variables
[ ] Rename Variables/defines/functions (where needed)

jlitewski commented 6 months ago

I finished up the rough implementation of palloc this morning. It is currently untested, but should work. I'm still going to need to write up some test suites for it to make sure it's all working as intended. Added that to the major milestones needed to hit

jlitewski commented 6 months ago

Finished up the rough implementation of tracer. Currently it's just the same functions that BigBuf had, but the future plans are to redo how all of the tracing stuff works to try and make it a bit more memory efficient.

jlitewski commented 6 months ago

Card Emulation stuff roughly implemented. I'm not sure how it all works, because it only looks like a storage buffer for card information based on a quick look over of the functions in BigBuf. If that's the case, I'm going to actually implement a card emulation system with it, because otherwise why do we have card emulation functions to begin with?

jlitewski commented 6 months ago

Started chipping away at moving things over. Been renaming things along the way to more agnostic names as well, added that to Minor Milestones. Hopefully can have this done by the end of the month, I'm tired of looking at this code 😆

jlitewski commented 6 months ago

12 more files. One of which is more than likely going to need to be partially rewritten to work correctly with palloc. The light at the end of the tunnel is getting bigger!

Hopefully I didn't break too much...

jlitewski commented 6 months ago

The firmware is now using Palloc/Tracer/CardEmu over BigBuf. It's highly unstable, but it's working. I got to go through and fix up the remaining bugs and regressions. I think I'm going to merge this into proxmark-nxtgen and finish development outside the nxtgen-palloc fork, since Iceman is preparing a release upstream and I have like a month of commits to merge