search

jlitola / play-sass

Sass asset handling for Play Framework 2.0 *DEPRECATED*
MIT License
90 stars 28 forks source link

Support for Play 2.1-RC1 and fix compilation of *.sass files #7

Closed tthraine closed 11 years ago

tthraine commented 11 years ago

The plugin supports Play 2.1-RC1 with this patches. There was also a bug which prevented compilation of *.sass files.

efuquen commented 11 years ago

Would it be wise to pull this into another branch perhaps and release a version that's compatible with play 2.1? I'm sure merging this in would break the plugin for play 2.0

tthraine commented 11 years ago

Yes, you're right, merging these patches would break compatibility with Play 2.0. But I would rather suggest to create a branch for 2.0, so work could continue for Play 2.1 in master. Anyways, I do not have the rights to do anything in this repo, so for now you can use https://github.com/tthraine/play-sass if your want Play 2.1 support. I'll try to keep up-to-date with new Play RC's as they arrive, and test the plugin against those new versions.

jlitola commented 11 years ago

I'll try to review the changes soon, and deploy Play 2.1 supporting version as 0.2.x.

durre commented 11 years ago

+1 for 2.1 support

jlitola commented 11 years ago

I ended up not using this pull request, as there were some unnecessary changes included and needed changes for switching from 2.0 to 2.1 were small. Anyhow, support for Play 2.1 is now in master, and I just published 0.2.0 which support Play 2.1.