search

jlkatz / OCTGN.OCTGNDeckConverter

A comprehensive OCTGN deck converter for OCTGN 3 which can convert several formats, websites, and plain text into the OCTGN 3 format.
http://octgngames.com/deckconverter/
7 stars 9 forks source link

Get install path for octgn #27

Closed BenMatteson closed 2 years ago

BenMatteson commented 3 years ago

This, hopefully reads the registry to check for non-default install path to find data.path. I've not worked with NSIS before, so check me on it. (also apparently github really wanted that newline at EOF)

jlkatz commented 3 years ago

Hi Ben, thanks for investigating this! I'm afraid this may already have been done though. About 2 months ago I made v3.9.0 which reads data.path according to OCTGN's latest version. Was there something I missed?

BenMatteson commented 3 years ago

I think so? again, I don't really know my way around NSIS scripts, but it looks like it uses a fixed path within appdata to find the data.path file, however this install location can also be changed, so that file might be somewhere else. What I tried to do here is have it look up the install path in the registry where the data.path file (the data path) can be found. it's kinda a weird setup that happened... somehow? I don't remember the whole story anymore, but the point is reading the data.path is correct and worked for most users, but it's not always in the same place.

brine commented 3 years ago

Hi Ben, thanks for investigating this! I'm afraid this may already have been done though. About 2 months ago I made v3.9.0 which reads data.path according to OCTGN's latest version. Was there something I missed?

I believe that fix was to handle a custom data directory location, but not OCTGN's core install location.