search

jlkiri / gatsby-remark-shiki

A Gatsby plugin for code highlighting with Shiki for use with gatsby-transformer-remark.
MIT License
6 stars 6 forks source link

Update Shiki #11

Closed watway closed 2 years ago

watway commented 2 years ago

Latest Shiki no longer exports getTheme and loadTheme requires path to the theme, not just the theme name. Change leaves the theme loading to getHighlighter.

jlkiri commented 2 years ago

Could you please only update Shiki's version if possible (so that package-lock is easier to check)?

watway commented 2 years ago

I have reverted those other packages back to original versions, the package-lock should be easier to read now.

jlkiri commented 2 years ago

Thanks! 👍

watway commented 2 years ago

hi @jlkiri, just wondering if you were planning on updating npm to include these changes? I'm in the process of updating the @mlent/gatsby-theme-help-center theme which has a dependency on this plugin, to Gatsby 4 but it won't build without the Shiki update.

jlkiri commented 2 years ago

Yes, I am planning to update the package asap. I am currently having problems with my account but it should be OK.

jlkiri commented 2 years ago

@watway Published as 0.3.0!

watway commented 2 years ago

Excellent, thanks for that @jlkiri

watway commented 2 years ago

Just linking in an issue created with gatsby-plugin-mdx preventing this plugin from working.

https://github.com/gatsbyjs/gatsby/issues/34015