search

jllodra / cmod3

cmod3 module (.IT, .XM, .S3M, .MOD...) music player
30 stars 10 forks source link

Files load in seemingly random order #13

Closed arkholt closed 7 years ago

arkholt commented 8 years ago

When adding a number of files, either by drag and drop or by using the "Add File" dialog, they load into the playlist in what appears to me to be a random order. Normally, I'd assume they should load in some kind of alphabetical order, either by title or by file name, but this is not the case. I did notice that when adding the same files again after clearing the playlist, it adds them again in the same order as before. Is there an explanation for this?

jllodra commented 8 years ago

You are right, because the file (and metadata) loading is done asynchronously, the order of files will be appear randomised. I will take a look at the loading code and use another approach.

Thank you

jllodra commented 8 years ago

OK, I think I got it... Songs show sorted now.

image

I will release a new version in a couple of days or maybe next weekend.

jllodra commented 7 years ago

This has been fixed in the latest minor release: 2.1.1

https://github.com/jllodra/cmod3/releases/tag/2.1.1

arkholt commented 7 years ago

In the latest version, 2.2.1, while the filenames do now appear, it appears that the files are not sorting properly, the same as before. I didn't mention anything about it in 2.1.1, since it appears from your screenshot that the files are sorted by filename, and I thought that maybe if the filename did not appear it's possible that it then wasn't sorting. However, now in 2.2.1 the sorting problem has returned. Should this issue be reopened?

jllodra commented 7 years ago

Reopening...

jllodra commented 7 years ago

I am uploading a new version, 2,2.2. I was only sorting files when folders were dropped, not when individual files were dropped. I have corrected this, it should work now. I am not closing the issue until you test this. Thank you.

arkholt commented 7 years ago

Files are now sorted properly when dragging and dropping a folder as well as dragging and dropping files. However, files do not sort properly when clicking the "Add Files" button and selecting them in the dialog.

jllodra commented 7 years ago

You are right, thank you, I never use the "Add files" button so I didn't notice. 2.2.3 will be available in a few minutes.

arkholt commented 7 years ago

In 2.2.3, file sorting does appear to work with the "Add Files" button, when dragging and dropping files, and when dragging and dropping folders.