search

jllodra / cmod3

cmod3 module (.IT, .XM, .S3M, .MOD...) music player
30 stars 10 forks source link

Implement loading and saving a playlist to the player #23

Closed smithmf closed 7 years ago

smithmf commented 7 years ago

This pull request implements saving the current playlist from the player and also adding songs to the current playlist from a previously saved playlist.

jllodra commented 7 years ago

Amazing, I haven't reviewed the pull request yet (will do as soon as possible) but you have made me very happy.

Honestly, when I created this Issue I never thought that anybody with skills would be interested in it. Are you familiar with Tracked music (module music)?

smithmf commented 7 years ago

@jllodra Perfect, let me know if you have any changes that are needed. I think the current Travis failure is due to the DNS issues that have been going on today...

No, I'm not really familiar with Tracked music, but I was interested in the technology. I've built Angular apps and written NodeJS servers, but never heard of nwjs. It looked interesting and I thought I could contribute.

jllodra commented 7 years ago

Hi @smithmf,

I have merged your PR. I have also added 2 buttons to load/save playlists as you suggested. I have also added your name as a contributor in the "about cmod3" section in the app.

The new version (2.2.1) will be released shortly.

Thank you for your time and your code!