search

jllodra / ncdump-json

Modified ncdump to output data in json format
86 stars 28 forks source link

support cdl without global attributes #8

Open ocehugo opened 9 years ago

ocehugo commented 9 years ago

If the cdl file has no global attributes, the json dump output of ncdump-json is invalid.

jllodra commented 9 years ago

Thank you for reporting, I'll try to make some research on it, I have very limited time to work on this. Pull requests are also welcome.

ocehugo commented 9 years ago

If i remember correctly, the problem was with a extra "}" at the end of the file. So pretty much believe that is some if global_attributes_present missing (the assumption that all files have them), that includes the extra "}".

jllodra commented 9 years ago

Makes sense, thanks for the research.

jllodra commented 9 years ago

Commit 3e5301c9e897fa46a4b1e114527d3c4e803e00a4 should fix this. :+1: