search

jlmelville / rnndescent

R package implementing the Nearest Neighbor Descent method for approximate nearest neighbors
https://jlmelville.github.io/rnndescent/
GNU General Public License v3.0
10 stars 2 forks source link

Better dqrng compatibility changes #16

Closed rstub closed 4 months ago

rstub commented 4 months ago

Use the original definition of dqrng::rng64_t instead of trying to use the new definition.

I think the issues we saw in https://github.com/daqana/dqrng/issues/80 stemming from my original patch are related to creating a new style dqrng::rng64_t within parallel code. That is something that is no longer possible, since it now uses Rcpp::XPtr.

jlmelville commented 4 months ago

Thank you for this @rstub I have confirmed it fixes the problem on my side.