search

jlnsrk / h265ify

Enable HEVC(H265) in Edge
MIT License
46 stars 5 forks source link

Clarify what is fixed? #1

Open indolering opened 1 year ago

indolering commented 1 year ago

I'm really confused as to what is getting fixed. Is h265ify fixing Edge's broken support for HEVC or is it trying to compensate for websites not testing the correct MIME strings?

kelvinkwong commented 1 year ago

Is h265ify fixing Edge's broken support for HEVC or

Technically yes, have a look at https://github.com/jlnsrk/h265ify/blob/60258dfe1e828d6caffaa6b54431d58f3568acd3/src/inject/inject.js#L49-L53 It appears to be assuming HEVC is supported by the browser.

is it trying to compensate for websites not testing the correct MIME strings?

No. Websites (more specially players like dash.js or hls.js) are testing for the correct MIME string however, the browser is returning the MIME (HEVC) string as not supported.

ghettopato commented 9 months ago

This was just a fix for when edge supported h265, but didn't announce it to websites. That has been rectified. This extension is useless now.

willmackey2nd commented 6 months ago

Well, at least for me the Edge still doesnt seem to be supporting HEVC. Frigate UI streaming some Reolink h265 just give errors to console The type provided ('video/mp4; codecs="hvc1.1.6.L153.B0,mp4a.40.2"') is unsupported. Same error, no matter if h265ify extension is installed or not.

Same page and stream play fine with Chrome, but not a fan of the resource hungry Chrome so would rather use Edge.

DatPat commented 6 months ago

Well, at least for me the Edge still doesnt seem to be supporting HEVC. Frigate UI streaming some Reolink h265 just give errors to console The type provided ('video/mp4; codecs="hvc1.1.6.L153.B0,mp4a.40.2"') is unsupported. Same error, no matter if h265ify extension is installed or not.

Same page and stream play fine with Chrome, but not a fan of the resource hungry Chrome so would rather use Edge.

You need to install the HEVC video extension from the windows store for edge to support hevc.

willmackey2nd commented 6 months ago

I have that one too and e.g. Windows Media player plays h265 recordings fine.

DatPat commented 6 months ago

I have that one too and e.g. Windows Media player plays h265 recordings fine.

windows media player? which version of windows are you using?

willmackey2nd commented 6 months ago

Win10 (19045 build). Meant the 'Media Player' app, but actually it seems to still have also the 'Windows Media Player' app too, but the former is the default one opening streams. Anyway, just meant that it's playing HEVC videos ok which means the MS store HEVC addon is installed fine.