search

jloehr / HID-Wiimote

Windows Device Driver for the Nintendo Wii Remote
GNU General Public License v3.0
216 stars 45 forks source link

Minor HID descriptor issue #38

Closed abend0c1 closed 6 years ago

abend0c1 commented 6 years ago

In HID-Wiimote/HID Wiimote/HIDDescriptors.c I think the following:

0x65, 0x12, // UNIT (SI Rot:Angular Pos)

...should be:

0x65, 0x14, // UNIT (English Rot:Angular Pos in Degrees)

...given that the logical values that the usage can have is 1 to 8, and the corresponding physical values are 0 to 315 in 45 degree increments i.e. physical = (logical - 1) * 45

The SI rotational unit is radians not degrees. Probably doesn't matter much...just sayin' :)

jloehr commented 6 years ago

Indeed, thanks for pointing that out 😄