search

jloh / nagios-nrpe-server

Nagios NRPE Server Role for Ansible
https://blog.jloh.co/nagios-nrpe-ansible-role/
MIT License
29 stars 38 forks source link

Several improvements #14

Closed franlr closed 8 years ago

franlr commented 8 years ago

Separate config paths for nagios main directory (/etc/nagios) and nrpe.d additional checks. Comment sample checks into nrpe.cfg Rewrite nrpe_ansible.cfg.j2 template to be able to add new additional checks from an array

jloh commented 8 years ago

I can't merge this as is. You've removed some Arch comparability for some reason and changed the README.md to be your own.

I do agree with a lot of the commit though. The role needs to move away from editing templates like it is now to variables.

If you're able to clean this commit up and remove the changes to README.MD (apart from the typo and any changes to how the role actually works) we can have a look again.

franlr commented 8 years ago

Don't worry about that. I will delete the fork.

Good luck with the new version!

Cheers.

El dom., 7 feb. 2016 a las 19:47, James (notifications@github.com) escribió:

I can't merge this as is. You've removed some Arch comparability for some reason and changed the README.md to be your own.

I do agree with a lot of the commit though. The role needs to move away from editing templates like it is now to variables.

If you're able to clean this commit up and remove the changes to README.MD (apart from the typo and any changes to how the role actually works) we can have a look again.

— Reply to this email directly or view it on GitHub https://github.com/Mooash/nagios-nrpe-server/pull/14#issuecomment-181077817 .