search

jloh / nagios-nrpe-server

Nagios NRPE Server Role for Ansible
https://blog.jloh.co/nagios-nrpe-ansible-role/
MIT License
29 stars 38 forks source link

enable server_address and disable example commands in nrpe.cfg template #22

Closed MrTango closed 7 years ago

MrTango commented 7 years ago

It makes sense to actually enable the server_address in the nrpe.cfg, otherwise the var for it does not have any effect. There is no need for the example commands being enabled by default in the template.

jloh commented 7 years ago

Ugh, yeah this is pretty dumb. This whole file needs a cleanup.

I'll merge this and release a new version soon with some other cleanups I've got in mind.

MrTango commented 7 years ago

thx, I'm also wondering if it would make sense to include the nagios-plugins packages in the role, as I use them just by name instead of copying them with the role. The copy makes sense for custom plugins which are not part of the packages.

jloh commented 7 years ago

On debian based OS' nagios-plugins is a dependency, so it's installed already. On RedHat based ones it's installed as a separate task.

Are you seeing otherwise?

MrTango commented 7 years ago

There is no hart dependency from nagios-nrpe-server to nagios-plugins. It didn't install it. I had to add it by my self. And i didn't find any explicit install in your role. That could be easy fixed.

jloh commented 7 years ago

What OS are you running?

jloh commented 7 years ago

Ugh I've just confirmed this on an ubuntu 16.04 machine, I've raised #23 to track.