jloh02 / pe

0 stars 0 forks source link

Invalid dates can be added #8

Open jloh02 opened 1 week ago

jloh02 commented 1 week ago

Negative years may be added due to user input. Although these can usually be safely ignored, in this case, an erroneous input may cause a user to believe that the event below starts on 21 December (without seeing the end date), when the user meant 12 Dec 2024 - 12 Dec 2024.

image.png

nus-pe-script commented 3 days ago

Team's Response

The example provided above is a rare case, and would be very unlikely to affect normal usage.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Such a typo can occur very naturally given the "-" key is close to the backspace and number keys on the keyboard ("9" above on the numpad and "0" on the main keyboard area). The impact on the user can be rather significant in storing incorrect dates as putting a "-" on the "from date" essentially ignores all checks that the "from date" must be before the "to date". This is occasional and can cause some inconvenience especially for typists who may type fast but not as accurately. However, it is something that can be worked around