jlong / css-spinners

Simple CSS spinners and throbbers made with CSS and minimal HTML markup.
http://www.css-spinners.com
MIT License
923 stars 157 forks source link

Dependency on Compass #5

Open maorcc opened 10 years ago

maorcc commented 10 years ago

I use SASS but not Compass. I see in _base.scss: @import "compass/css3"; Can the dependency on Compass be avoided?

jlong commented 10 years ago

Bourbon could be used instead or perhaps something like Prefix-free. Seems like it would be nice if there was a way of specifying which library you want to use.

Pull-requests welcome.

xmlking commented 10 years ago

I am using https://github.com/yeoman/generator-gulp-webapp generated project with Bourbon to manage my project SASS files, no Compass runtime. Wish if you could support Compass free SASS so that we can build our leaner final css using project specific build process.

xmlking commented 10 years ago

As a workaround,

  1. I added compass-mixins to my project bower.json file,
  2. updated spinner/_base.scss with @import "../../../compass-mixins/lib/compass/css3";
  3. Added _function.scss to my main.scss to fix this Wish to see a permanent or better solution to automate my SASS pre-processing task...

main.scss

@import "variables";
$icon-font-path: "../bower_components/bootstrap-sass-official/vendor/assets/fonts/bootstrap/";

/* to Fix http://stackoverflow.com/questions/11649016/compact-function-in-bourbon-with-sass-not-called */
@import "function";

// bower:scss
@import "../bower_components/bootstrap-sass-official/vendor/assets/stylesheets/bootstrap.scss";
@import "../bower_components/bourbon/dist/_bourbon.scss";
@import "../bower_components/css-spinners/sass/spinner/spinner.scss";
// endbower

@import "animations";

bower.json

    "dependencies": {
        "bootstrap-sass-official": "~3.1.1",
        "bourbon": "~4.0.1",
        "compass-mixins":">=1.0.0",
        "animate.css": "~3.1.0",
        "css-spinners": "jlong/css-spinners",
        .
        .
        .
   },
   "overrides": {
        "css-spinners": {
            "main": "sass/spinner/spinner.scss"
        }
    }
shubhendrapatel commented 6 years ago

since we are already using GULP, we can use Autoprefixer which can add prefixes during build process. In addition to this we can also create a watch task which will compile when we make changes and it will automatically run tasks. It will make development little bit easier.

shubhendrapatel commented 6 years ago

@jlong what do you think

jlong commented 6 years ago

I agree. Autoprefixer is way better.