search

jlong / css-spinners

Simple CSS spinners and throbbers made with CSS and minimal HTML markup.
http://www.css-spinners.com
MIT License
923 stars 157 forks source link

Added !default to the $spinner-color variable in SASS so it can be overridden with a different color. #6

Closed darrenhaken closed 10 years ago

darrenhaken commented 10 years ago

Using !default against a variable in SASS means it will not be overwritten if it's already been defined. This means the colour can be overridden in projects using the library.

This should probably be done for all color variables in the library. Might I suggest you could extract this into a different sass file such as '_config.scss'. If you would like help doing this I'd be happy to provide further pull requests.

Once you've accepted the pull request could you also push this to bower so I can install it.

Thanks,

Darren

jlong commented 10 years ago

Thanks!

darrenhaken commented 10 years ago

Is this now pushed to bower?

On 10 June 2014 14:40, John W. Long notifications@github.com wrote:

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/jlong/css-spinners/pull/6#issuecomment-45614170.