add support for dashed attributes (e.g. data-role)

jlong / radius

A small, but powerful tag-based template language for Ruby modeled after the ones used in MovableType and TextPattern. It has tags similar to XML, but can be used to generate any form of plain text (HTML, e-mail, etc...).

MIT License

101 stars 21 forks source link

add support for dashed attributes (e.g. data-role) #20

Closed yurivm closed 5 years ago

yurivm commented 10 years ago

I am using radius to render rails templates for a site that uses a lot of data-* attributes in tags. Attempting to specify such an attribute, e.g.

<r:tag data-value="43">

raises an exception as radius does not expect the attribute names to contain dashes.

The fix is quite simple. Tested on MRI 1.9.3 and 2.0.0.

saturnflyer commented 10 years ago

Thanks! Not sure what's up with travis. I'm happy to merge once this is running on all versions. Although dropping 1.8.7 would be fine I'd rather get the others running.

yurivm commented 10 years ago

I'll look into it a bit more - the errors are about dependencies and being unable to install rubinius as binary.

saturnflyer commented 10 years ago

Thanks. Yeah I looked a bit but haven't had time to check so I'm just making notes here.

yurivm commented 10 years ago

Ok, so I had to update the .travis.yml:

as rbx-19mode / rbx-18mode is no longer supported by travis, I updated the travis.yml / gemfile for the rubinius build to work
jruby in 1.8 mode won't work because of gem dependency issue. jruby in 1.9 mode won't install (travis issues). It's kind of funny that most of the fuzz is caused not by radius but by coveralls/simplecov.

Anyway, the build is green now.