search

jlong / radius

A small, but powerful tag-based template language for Ruby modeled after the ones used in MovableType and TextPattern. It has tags similar to XML, but can be used to generate any form of plain text (HTML, e-mail, etc...).
MIT License
101 stars 21 forks source link

support attribute names with dash #22

Closed ronald closed 5 years ago

ronald commented 5 years ago

Radius 0.7.4 raises Radius::WrongEndTagError (wrong end tag snippet' found for start tag' with stack []): on 

  <r:snippet name="head" jquery-version="some-version">
    some content
  </r:snippet>

Radius 0.6.1 doesn't raise an exception.

related to #12

My branch name is wrong (underscore was already working).

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 96.429% when pulling 2edbaee03f441726b1f0a4f5f73678ccfbd096ba on manet-marketing:feature/support-underscore-in-attribute-names into b90c706b4dffc259377ef0fdc7d86764db7befc5 on jlong:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 96.429% when pulling 2edbaee03f441726b1f0a4f5f73678ccfbd096ba on manet-marketing:feature/support-underscore-in-attribute-names into b90c706b4dffc259377ef0fdc7d86764db7befc5 on jlong:master.

saturnflyer commented 5 years ago

Thank you so much for this @ronald!

I've merged https://github.com/jlong/radius/pull/20 in favor of it being more complete. I had forgotten that it existed but had asked for a Ruby version support be maintained in CI but didn't get that change. I've addressed my concerns and am updating the ci config to include later versions of Ruby and will cut a new gem.