search

jlong / serve

Serve is a small Rack-based web server and rapid prototyping framework for Web applications (specifically Rails apps). Serve is meant to be a lightweight version of the Views part of the Rails MVC. This makes Serve an ideal framework for prototyping Rails applications or creating simple websites. Serve has full support for Rails-style partials and layouts.
http://get-serve.com
Other
836 stars 90 forks source link

Feature/jsx #117

Closed haf closed 9 years ago

haf commented 10 years ago

Getting this when including a jsx file... What's wrong with the method I'm using to include the file?

/Users/henfel/.rbenv/versions/1.9.3-p545/lib/ruby/1.9.1/forwardable.rb:204: stack level too deep (SystemStackError)
haf commented 10 years ago

Build is failing on Ruby 1.8 syntax stuff. Why do we care about 1.8?

haf commented 10 years ago

I've read through the code now... Why not just use the file extensions to generate the exported files? Instead of running misc commands and hacking around? And what's up with the 'ugly but works' comments? Wtf per minutes was high there for a while. The export code could use some refactoring too.

wazery commented 9 years ago

Good PR, thanks @haf but unfortunately can't merge due to the faild build on Travis. Ruby 1.8 is not supporting the new hash syntax that came up with Ruby 2, so Travis fails because of it.

@jlong Do you think we need to drop support for Ruby 1.8? It's a bit outdated now.

haf commented 9 years ago

I'm sorry, but my interest in this PR has timed out. You are welcome to use the code, however, and I release it to the public domain.