search

jlong / serve

Serve is a small Rack-based web server and rapid prototyping framework for Web applications (specifically Rails apps). Serve is meant to be a lightweight version of the Views part of the Rails MVC. This makes Serve an ideal framework for prototyping Rails applications or creating simple websites. Serve has full support for Rails-style partials and layouts.
http://get-serve.com
Other
836 stars 90 forks source link

filename case is breaking new project generation #33

Closed sid137 closed 13 years ago

sid137 commented 13 years ago

$ serve create server exists server exists server/public exists server/tmp exists server/views exists server/config.ru /home/sid137/.rvm/gems/ruby-1.8.7-p334/gems/serve-1.5.0.pre2/lib/serve/project.rb:117:in read': No such file or directory - ../../.rvm/gems/ruby-1.8.7-p334/gems/serve-1.5.0.pre2/lib/serve/templates/license (Errno::ENOENT) from /home/sid137/.rvm/gems/ruby-1.8.7-p334/gems/serve-1.5.0.pre2/lib/serve/project.rb:117:inread_template' from /home/sid137/.rvm/gems/ruby-1.8.7-p334/gems/serve-1.5.0.pre2/lib/serve/project.rb:76:in setup_base' from /home/sid137/.rvm/gems/ruby-1.8.7-p334/gems/serve-1.5.0.pre2/lib/serve/project.rb:23:increate' from /home/sid137/.rvm/gems/ruby-1.8.7-p334/gems/serve-1.5.0.pre2/lib/serve/project.rb:39:in create' from /home/sid137/.rvm/gems/ruby-1.8.7-p334/gems/serve-1.5.0.pre2/lib/serve/application.rb:23:inrun' from /home/sid137/.rvm/gems/ruby-1.8.7-p334/gems/serve-1.5.0.pre2/lib/serve/application.rb:11:in run' from /home/sid137/.rvm/gems/ruby-1.8.7-p334/gems/serve-1.5.0.pre2/bin/serve:16 from /home/sid137/.rvm/gems/ruby-1.8.7-p334/bin/serve:19:inload' from /home/sid137/.rvm/gems/ruby-1.8.7-p334/bin/serve:19

sid137 commented 13 years ago

I'm sorry, it looks like you already fixed this previous issue in your branch, by lowercasing the actual filename (instead of uppercasing as I did in my patch). So my patch re-breaks this.. you should probably undo it. I was using the -pre2 gem, which looks like it came out before you applied the fix in github

jlong commented 13 years ago

Ok, I'm confused. Why does referencing the filename with it's actual case "LICENSE" not work? You are on Windows? or Unix?

sid137 commented 13 years ago

Because according to your github master branch, the actual filename is now "license".

https://github.com/jlong/serve/blob/master/lib/serve/templates/license

I'm on linux.. howevver in the gem I was using it was "LICENSE" which was what I submitted the patch based on. So I should have checked the actual filename in github, instead of assuming that it was the samee as the actual filename in my gem

jlong commented 13 years ago

I decided to delete the license file and allow folks to create their own license for a project. Since so may Serve projects are proprietary, this seemed like a good idea.