search

jlong / serve

Serve is a small Rack-based web server and rapid prototyping framework for Web applications (specifically Rails apps). Serve is meant to be a lightweight version of the Views part of the Rails MVC. This makes Serve an ideal framework for prototyping Rails applications or creating simple websites. Serve has full support for Rails-style partials and layouts.
http://get-serve.com
Other
836 stars 90 forks source link

Serve create has Sass and Compass dependencies #35

Closed imathis closed 12 years ago

imathis commented 13 years ago

Serve's create command generates a project example which relies on Sass and Compass. I set up a new project, installed Serve, ran serve create . and then serve and it complained that it needed Sass (then Compass later). It seems to me that either Sass and Compass should be included as dependencies of Serve, or the create command should output a little message saying "Serve has generated a basic project for you in #[directory}. Make sure you have 'compass' gem or [take whatever steps necessary to remove Compass]"

I'm not sure what is best, but /project/config.ru:16:in require': no such file to load -- sass (LoadError) doesn't make for a very nice first run experience.

jlong commented 13 years ago

Good thoughts Brandon. I added a post install message to the gem about this last night. I like the idea of having config.ru generate a nicer message. Shouldn't be too hard to fix..

jlong commented 13 years ago

So I've added a Gemfile to generated Serve projects which should help with this, too:

https://github.com/jlong/serve/blob/master/lib/serve/templates/Gemfile

ntalbott commented 12 years ago

So is this resolved now to your satisfaction @imathis?

imathis commented 12 years ago

@ntalbott that file doesn't seem to exist anymore. At least not in that location.

jlong commented 12 years ago

It's here: https://github.com/jlong/serve/blob/master/lib/serve/bootstrap/Gemfile

imathis commented 12 years ago

I like it. The post create message is a nice touch: https://github.com/jlong/serve/blob/master/lib/serve/project.rb#L132

As I understand it though, Serve still requires Compass and Sass. Even if you remove them from the Gemfile, you still must have them installed in order to use Serve. It should be in the project Gemfile, but it if my assumption is correct, it seems like it should also be a dependency of Serve.

I'll close this issue, and leave it up to you to decide what whether to create an issue about adding Compass/Sass as a dependency.

jlong commented 12 years ago

Serve doesn't require Sass or Compass. The serve create command bakes this functionality in, but it's not a requirement.