search

jlong / serve

Serve is a small Rack-based web server and rapid prototyping framework for Web applications (specifically Rails apps). Serve is meant to be a lightweight version of the Views part of the Rails MVC. This makes Serve an ideal framework for prototyping Rails applications or creating simple websites. Serve has full support for Rails-style partials and layouts.
http://get-serve.com
Other
836 stars 90 forks source link

Fixed small typo with generated config.ru file #82

Closed marcelow closed 12 years ago

marcelow commented 12 years ago

Hey John. What's up? I just fixed a small typo on the generated config.ru file (Passendger -> Passenger). As I side note, I think that the docs at http://get-serve.com/documentation/coffee-script are a bit wrong. Wouldn't it be "require 'rack-coffee'" instead of "gem 'rack-coffee'" in the config.ru file?

Hope I've helped!

Marcelo Wiermann

travisbot commented 12 years ago

This pull request passes (merged b6c215ba into ad61cca3).

jlong commented 12 years ago

Thanks @marcelow! You are probably right about CoffeeScript. If you want to send me another pull request for that I'll merge it too. Have a look in the website/ directory.

marcelow commented 12 years ago

Hey @jlong, glad to help! I did look for the coffeescript doc page (even with grep -nr) on the cloned repo but I didn't find it, that's why I pointed that out in the pull request. BTW, the syntax that actually worked for me was

    require 'rack/coffee' 
    use Rack::Coffee,
      :root => 'public', 
      :urls => '/javascripts/'

Anyway, thanks for the great tool!

jlong commented 12 years ago

Wow. Interesting. Looks like I had some unpushed changes. It's up there now, and I've updated the docs a bit. Let me know what you think.

--John

On Aug 9, 2012, at 2:26 PM, marcelow notifications@github.com wrote:

Hey @jlong, glad to help! I did look for the coffeescript doc page (even with grep -nr) on the cloned repo but I didn't find it, that's why I pointed that out in the pull request. BTW, the syntax that actually worked for me was

require 'rack/coffee' 
use Rack::Coffee,
  :root => 'public', 
  :urls => '/javascripts/'

Anyway, thanks for the great tool!

— Reply to this email directly or view it on GitHub.

marcelow commented 12 years ago

Hey John, sorry for the late response. Looks great! I was actually going to ask you about the .coffee files path on the old docs, but the new docs seems to point to paths that better reflect the stylesheets one (if I'm not mistaken I had to put the .coffee files directly on the /public/javascripts, where only the compiled versions should go). Thanks for the update :)

On Thu, Aug 9, 2012 at 9:49 PM, John W. Long notifications@github.comwrote:

Wow. Interesting. Looks like I had some unpushed changes. It's up there now, and I've updated the docs a bit. Let me know what you think.

--John

On Aug 9, 2012, at 2:26 PM, marcelow notifications@github.com wrote:

Hey @jlong, glad to help! I did look for the coffeescript doc page (even with grep -nr) on the cloned repo but I didn't find it, that's why I pointed that out in the pull request. BTW, the syntax that actually worked for me was

require 'rack/coffee' use Rack::Coffee, :root => 'public', :urls => '/javascripts/' Anyway, thanks for the great tool!

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/jlong/serve/pull/82#issuecomment-7631448.

jlong commented 12 years ago

Cool. Glad you like it. :)

--John

On Aug 13, 2012, at 6:41 PM, marcelow notifications@github.com wrote:

Hey John, sorry for the late response. Looks great! I was actually going to ask you about the .coffee files path on the old docs, but the new docs seems to point to paths that better reflect the stylesheets one (if I'm not mistaken I had to put the .coffee files directly on the /public/javascripts, where only the compiled versions should go). Thanks for the update :)

On Thu, Aug 9, 2012 at 9:49 PM, John W. Long notifications@github.comwrote:

Wow. Interesting. Looks like I had some unpushed changes. It's up there now, and I've updated the docs a bit. Let me know what you think.

--John

On Aug 9, 2012, at 2:26 PM, marcelow notifications@github.com wrote:

Hey @jlong, glad to help! I did look for the coffeescript doc page (even with grep -nr) on the cloned repo but I didn't find it, that's why I pointed that out in the pull request. BTW, the syntax that actually worked for me was

require 'rack/coffee' use Rack::Coffee, :root => 'public', :urls => '/javascripts/' Anyway, thanks for the great tool!

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/jlong/serve/pull/82#issuecomment-7631448.

— Reply to this email directly or view it on GitHub.