Open arsnyder16 opened 2 years ago
I published a new version of @jlongster's fork which contains the fix here: https://www.npmjs.com/package/@aphro/sql.js
You can see an example of it in use here: https://aphrodite-examples.pages.dev/todo-mvc/
@tantaman can you provide a link to the repo your change was in? I do not see any updates on the last 2 months for the repo's linked.
oops, looks like I never actually pushed the changes but only published them to npm. Fixed that.
I merged the latest sql.js
changes in with @jlongster's changes here: https://github.com/tantaman/sql.js/tree/alt-deploy
And updated absurd-sql to use that new sql.js package here: https://github.com/tantaman/absurd-sql/tree/alt-deploy
Note that these are in the "alt-deploy" branches. "alt-deploy" since the package names are changed for publishing to npm.
@jlongster It appears that the npm package you have psoed for sql.js does not include the following commit
https://github.com/sql-js/sql.js/commit/ec44c18a421ea2d9934acbc54fc12b31b35635eb
We are seeing this memory leak and with large data sets its pretty severe
Your fork does include this commit but the npm package for 1.6.7 looks like it was created Aug 8th which would not have contained this fix
Is it possible to get a new package created? I notice you are attempting to merge you sql.js branch back into the upstream but it hasn't been completed.