search

jlongster / transducers.js

A small library for generalized transformation of data (inspired by Clojure's transducers)
BSD 2-Clause "Simplified" License
1.73k stars 54 forks source link

Added self-returning Symbol.iterator/@@iterator method to iterators #38

Closed jaawerth closed 7 years ago

jaawerth commented 8 years ago

closes #37

  1. Adds self-returning protocols.iterator method to created iterators
  2. For consistency, wraps malformed iterators with same
  3. Updates the iterator test to check for iter[protocol]() === iter
jaawerth commented 8 years ago

Hi @jlongster,

Have you had a chance to take a look at it, and does that look alright for a merge? I've been using my fork for the ES6 interop, but I'm trying not to forget to check in before switching back. Thanks!

jaawerth commented 7 years ago

Due to inactivity, I'm going to close this for now so I can create a clean fork with the fix and publish it scoped, pointing back to this one. May recreate later.

jlongster commented 7 years ago

@jaawerth I'm sorry! I dropped out of open source for much of 2016 but I am watching things now, but haven't gone through all the old stuff. If you reopen this I can merge it.

jaawerth commented 7 years ago

@jlongster No worries; figured it was something like that, but I wanted to use this in a new project so I figured I'd just publish a fork, but no need with you back in open sourceville - welcome back!

Since I'd foolishly created this PR from the master branch of my clone, I closed this one so I could create a new fork and use master for an updated README/package.json and such. That means I can't revert anything here, but I'll get you a new PR shortly.