search

jlopp / statoshi

Bitcoin Core + StatsD integration
https://jlopp.github.io/statoshi/
MIT License
233 stars 26 forks source link

add stats for fee & priority estimates #11

Closed jlopp closed 9 years ago

jlopp commented 9 years ago

might have to add another RPC hook to call them with blocknotify

arnuschky commented 9 years ago

Having this would be great. It allows users to estimate themselves the fees per kb without running a node. I propose two stats, one for estimatefee 1 and one for estimate 3 RPC calls.

This statistic (together with mempool size) might be very useful wrt to the upcoming stresstest.

jlopp commented 9 years ago

Hey @arnuschky, I actually coded this up months ago but had a problem with converting ints to strings for the metric names - when I tested the patch it resulted in the metric names being completely corrupted and unusable because they weren't aggregating properly.

I'm terrible at C++; if you have any advice for what's wrong with my code, please comment at https://github.com/jlopp/statoshi/commit/ab08bbb5ff7f76767656b1bde2abea35fca832e6

arnuschky commented 9 years ago

I commented over there.

jlopp commented 9 years ago

Merged in cd25550c25ab06fc1e9fdc5d1cf04304d6f56d50 Apparently the problem fixed itself once I declared the stat names as explicitly typed string variables. shrugs

arnuschky commented 9 years ago

Awesome! Looking forward to seeing this on statoshi.info :)

jlopp commented 9 years ago

It's built and ready to deploy, but I don't want to restart the statoshi.info node until the latest stress test is over since restarting would clear out the mempool :-/

arnuschky commented 9 years ago

Ok, nice - thanks for letting me know. It would be awesome to have a new "block discussion" panel - for example block size/percentage used and paid fees vs. estimated fees. I can add this myself, if I understand correctly, right?

jlopp commented 9 years ago

Correct; if you have a login on statoshi.info then you can create whatever dashboards you want - the configuration guide is linked on the main page. If you create anything you think would be useful, you can export the JSON and send it to me and I'll consider adding it to the global dashboards.

arnuschky commented 9 years ago

Ok will do.