search

jlord / sheetsee.js

:eyes: :chart_with_upwards_trend: Visualize Data from a Google Spreadsheet
jlord.github.io/sheetsee.js
Other
2.96k stars 883 forks source link

Why is the Pie Chart so terrible - makeColorArrayOfObject() #7

Closed jlord closed 11 years ago

jlord commented 11 years ago

The colors aren't showing up and the labels on the right are jank ( but I think that's an issue with my d3 for this pie chart).

The colors are jank it seems because makeColorArrayOfObject() isn't working correctly.. even though in my other server-side working version there hadn't been a problem.

It is suppose to be taking the array of hexcolors it's given and then inserting them into a new object inside of an array that will be passed into a d3.

When you return the data from makeColorArrayOfObject, you can see it's not placing the color.

screen shot 2013-05-19 at 12 21 04 am

it is called here: https://github.com/jllord/sheetsee.js/blob/gh-pages/index.html#L388-L390

and defined here: https://github.com/jllord/sheetsee.js/blob/gh-pages/js/sheetsee.js#L205-L218

I think it has something to do with the number of colors it's given? When I gave it a larger array of colors it placed one color in the output array position 1, but was still undefined in position 0. Hmm.

/ cc @maxogden

jlord commented 11 years ago

The color issue has been fixed with the commit above.

I'm hoping to change the way labels are done entirely on this chart and instead of generating the text list to the right, to have a label appear on hover the same way it does on the line graph. I've tried some but haven't been able to get it to work. Will keep hacking at it.

jlord commented 11 years ago

Closing this because the basic Pie Chart works now, though later I'd like to spend some more time styling the labels differently.