search

jlouis / enacl

Erlang bindings for NaCl / libsodium
MIT License
197 stars 59 forks source link

Mixed tabs and spaces inside of files #12

Closed spscream closed 6 years ago

spscream commented 7 years ago

@jlouis, I'm adding some functions to nif currently(for key exchange) and found what your sources have mixed spaces and tabs inside of the erl and c sources.

Which one style do you prefer? I think it would make sense to add .editorconfig file to this library, so contributors could use it?

jlouis commented 7 years ago

Spaces only. It is just that when you use an editor which copies from the line before it and there is a tab character somewhere, it gets distributed around.

spscream commented 7 years ago

Could you fix it yourself, or should I make a pr for you?

I'm using this config by default in my vim: " Softtabs, 2 spaces set tabstop=2 set shiftwidth=2 set shiftround set expandtab

jlouis commented 7 years ago

I'll do stuff tomorrow, so if you haven't done it by then, I'll just do it :)

On Sun, Mar 19, 2017 at 12:09 AM Alexander Malaev notifications@github.com wrote:

Could you fix it yourself, or should I make a pr for you?

I'm using this config by default in my vim: " Softtabs, 2 spaces set tabstop=2 set shiftwidth=2 set shiftround set expandtab

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jlouis/enacl/issues/12#issuecomment-287581653, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAWH4wtkrUpp1AZ2i4nUt4HmJX4JcFZks5rnGQpgaJpZM4MhhmW .