Closed spscream closed 4 years ago
@spscream thanks for the patch. I would love to see a release with it :)
I'll patch it today
On Tue, Feb 25, 2020, 11:17 Benoit Chesneau notifications@github.com wrote:
@spscream https://github.com/spscream thanks for the patch. I would love to see a release with it :)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jlouis/enacl/pull/44?email_source=notifications&email_token=AAABMH5TFD2SWHB57M4QATLRETV2HA5CNFSM4KZJ4CF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM3MEOI#issuecomment-590791225, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABMH74QGQJWOIDKSXAOCTRETV2HANCNFSM4KZJ4CFQ .
As for tests, I'll do the EQC parts, so don't worry about them :)
Thanks for review. Added new changes
Pulling this. There are still some smaller nitpicks, but we'll short them out in-tree. Good work!
Added a CT unit test for these functions as well. It is a fine start. Wanting to add EQC tests later, but we gotta start somewhere :)
prop_secretstream: ....................................................................................................(x10)....................................................................................................(x100)..........................................................................................................(x10)...(x1)......
Time limit reached: 1.538 seconds.
OK, passed 11736 tests
Code is in the repo now.
Added libsodium secretstream bindings. I'm not sure how to add tests to enacl and run them correctly. So I wrote tests and check all functions are working on local Elixir project with enacl dependency.