pwhash_limit typespec is not available

jlouis / enacl

Erlang bindings for NaCl / libsodium

MIT License

197 stars 59 forks source link

pwhash_limit typespec is not available #59

Closed serokellcao closed 3 years ago

serokellcao commented 3 years ago

As reported here, valid pwhash_limit atoms aren't enumerated in typespec "exported" by enacl. Is there a particular reason for that, or PR adding it would be a good contribution?

jlouis commented 3 years ago

It's likely an oversight. I think we should have that.

jlouis commented 3 years ago

Does https://github.com/jlouis/enacl/commit/20b230d693ba4c0053ab044be5442fdb6e6b61f0 look right to you? I could cut a point-release if it looks ok.

serokellcao commented 3 years ago

Thank you! I didn't review thoroughly, but it looks like it does what I need.

jlouis commented 3 years ago

I pushed it out as 1.2.1 now.