search

jlouns / gulp-requirejs-optimize

Wrapper for the requirejs optimizer for use in gulp
MIT License
62 stars 9 forks source link

Plugin braking the pipe. Plumber doesn't help #5

Closed maciekpaprocki closed 9 years ago

maciekpaprocki commented 9 years ago

Hi I have huge watch task for my project and every single time i save on of js file with some error it's braking. I tried to fix it with plumber, but still brakes. On error is triggered but then it throws error either way. my code:

 return gulp.src(SCRIPTS_SRC + '*.js')
        .pipe(plugins.plumber({
            errorHandler: onError
        }))
        .pipe(plugins.requirejsOptimize())
        .pipe(plugins.plumber.stop())
        .pipe(gulp.dest(SCRIPTS_DEST));

Any ideas what might be the issue?

jlouns commented 9 years ago

I just put together a quick test where requirejsOptimize throws an error and plumber is keeping the pipe open for me. Are you using the latest versions of the plugins? Is requirejs throwing the error or is it the plugin before it even calls requirejs?

maciekpaprocki commented 9 years ago

Ok, I don't know how, but problem stopped existing after update, were it was installed 5 days ago on latest :). Sorry and thanks for support.