jlpteaching / dinocpu

A teaching-focused RISC-V CPU design used at UC Davis
BSD 3-Clause "New" or "Revised" License
140 stars 39 forks source link

Fixes for the problem where two TargetDirAnnotation cause Driver.execute to fail. #121

Closed chick closed 4 years ago

chick commented 4 years ago

This eliminates an, I believe, unnecessary call to getAnnotations which is causing the duplication. getAnnotations is used internally by Driver.execute and it is where the TargetDirAnnotation is added. I heard a report you were having this problem. It looks like you may already be trying to move to state /phase so this may not be necessary. Let me know if you have questions.

seldridge commented 4 years ago

Namely, this should fix #84.