search

jlr / rainbow-delimiters

Emacs rainbow delimiters mode
http://www.emacswiki.org/emacs/RainbowDelimiters
112 stars 12 forks source link

The default value of rainbow-delimiters-ignore-modes should be nil #33

Closed Fanael closed 9 years ago

Fanael commented 10 years ago

The only reason rainbow-delimiters-ignore-modes is not nil by default is it being a sop to misbehaved upstream projects (see #31).

Please tell the upstream developers to update their code to propertize with font-lock-face instead of just face so font-lock-mode doesn't overwrite their highlighting, so it's possible to remove this workaround from rainbow-delimiters.

bbatsov commented 10 years ago

I've made this changes to CIDER's REPL, but it's still not playing nice with rainbow-delimiters. Any ideas?

Fanael commented 10 years ago

What do you mean by not playing nice? Please post a screenshot and the result of (buffer-string).

bbatsov commented 10 years ago

My bad. As soon as I did (buffer-string) I found the problem - there were a few remaining face references that I hadn't updated. You can now remove cider-repl-mode from the ignore-modes I guess.

Fanael commented 10 years ago

Already removed, see 3a18183db.

purcell commented 10 years ago

LOL - I was just about to push an identically-named commit when I saw you'd beaten me to it.

Fanael commented 9 years ago

Closing in favor of #40.