search

jluastro / PopSyCLE

Population Synthesis for Compact-object Lensing Events
https://popsycle.readthedocs.io/en/latest/
16 stars 3 forks source link

Track more info #17

Closed samrose30 closed 4 years ago

samrose30 commented 4 years ago

This branch will allow the tracking of metallicity, bolometric luminosity, surface gravity, and effective temperature. These values for stars are taken directly from the ebf file generated by galaxia, and for compact objects are currently assigned as nan (clearly NSs and WDs do have real values for some of these so that should probably be addressed at some point). This branch also includes a new test written to compare h5 file outputs of perform_pop_syn.

MichaelMedford commented 4 years ago

This looks great! I've left line specific comments above. I think we should also change the column lum back to mbol, as it is in the Galaxia documentation.