jlubcke / tri.struct

tri.struct supplies classes that can be used like dictionaries and as objects with attribute access at the same time

BSD 3-Clause "New" or "Revised" License

2 stars 2 forks source link

MANIFEST.in: Include tests #5

Open jayvdb opened 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #5 into master will increase coverage by 0.46%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   97.33%   97.79%   +0.46%     
==========================================
  Files           1        3       +2     
  Lines         225      318      +93     
  Branches        4       13       +9     
==========================================
+ Hits          219      311      +92     
- Misses          4        5       +1     
  Partials        2        2

boxed commented 5 years ago

I've discussed this with @jlubcke and we don't agree the this is a good idea. This seems to only be applicable to your rather narrow use case but everyone else gets the test code which is just a waste of disk space.

jayvdb commented 5 years ago

sdists are for source distribution, compilation and verification. Wheels are for installation, esp. for binaries.

Narrow? All distros need this.

I've only proposed it for tri.struct, which is compiled and this is where it is most needed.

boxed commented 5 years ago

Hmm.. good point. I'll discuss it with @jlubcke.