jlucaspains / sharp-cooking-web

Web app for Sharp Cooking
MIT License
11 stars 2 forks source link

Add Folders for recipes #163

Open Tann2019 opened 1 year ago

Tann2019 commented 1 year ago

Giving the User the ability to create folders and move existing and new recipes into said folders would allow users with extensive recipe lists the ability to categorize down and make the interface less cluttered and organized.

jlucaspains commented 1 day ago

@Tann2019, could you use the preview version in the PR above and provide some feedback? The current version is not final, but, it should be a good start.

Tann2019 commented 1 day ago

@jlucaspains, Yeah for sure, I'll give it a whirl!

Tann2019 commented 1 day ago

@jlucaspains First impressions on #368 is great! A few of my observations may be from the start of the feature and just not implemented yet.

These are just my thoughts on the initial run-through, I'll take a look at the PR possibly tomorrow or sometime this week if you want 😊. Looking great!

jlucaspains commented 1 day ago

Thanks for testing @Tann2019. Here are my notes about your suggestions:

  1. Nice suggestion. I will implement it.
  2. I thought about that but wasn't sure if it would be good. Maybe we can use a toggle in the options?
  3. See below:
    1. Good catch. I will fix it.
    2. Are you running the app locally? I took the lazy route of not setting up the image parser locally. If you use the link in the PR, that one works correctly.
    3. Yep. Just WIP. However, I did consider making categories immutable.

thanks for the feedback!

Tann2019 commented 1 day ago

A toggle would be great! I was running locally since I still had the repo pulled down. Excited to see more of what's to come!

jlucaspains commented 20 hours ago

I got some of the changes done.

  1. The count of recipes in the category was added.
  2. I didn't change this yet.
  3. See below:
    1. Fixed
    2. No issue
    3. Fixed

I have also implemented the missing capability of adding a recipe directly to a category.

Tann2019 commented 17 hours ago

Nice Nice, I noticed the localization for the edit button isn't there yet,

Screenshot 2024-12-01 at 8 03 38 PM

Also, the Image parser does take a little bit to upload the image sometimes, especially if its big, maybe a spinner would help show that its working, since I tried to upload and image, it wasn't doing anything, then I created it without an image and went to create another one, and the image I was uploading popped up there.

Getting close to closing this up! May be Blog Post worthy 👀