jlumbroso / free-disk-space

:octocat:⚙️🗑️ A GitHub Action to free disk space on an Ubuntu runner.
MIT License
385 stars 72 forks source link

Fix errors related to executing dotnet #16

Closed ywt114 closed 1 year ago

ywt114 commented 1 year ago

The problem arises from rm rf/usr/share/dotnet. The solution is to first run apt-get update to update the software package list, and then run apt-get remove - y '^ dotnet -. ' to solve the execution error issue. I have tested and just submitted the issues, but I don't know if they will be killed. You can also fork the project and modify it yourself in the action.yml file by adding a sudo apt-get update before line 174, And there is a duplication between sudo rm - rf/usr/share/dotnet and sudo apt-get remove - y '^ dotnet -. '. Change to sudo rm - rf/usr/share/dotnet | | true and sudo apt get remove - y '^ dotnet -. *' | | true

normanmaurer commented 1 year ago

Please consider merging this one... Without this PR builds will continue to fail

thorstenwagner commented 1 year ago

Workaround: If you set only android to true, it runs.

subhamkrai commented 1 year ago

Please consider this change, we are also facing issue with google-cloud pkg

subhamkrai commented 1 year ago

@jlumbroso @gruve-p @rake5k ^^

gruve-p commented 1 year ago

@jlumbroso @gruve-p @rake5k ^^

I am not the maintainer of this repo nor do I have any merge rights, Pinging me will not solve your request.

jlumbroso commented 1 year ago

@ywt114 Thanks for your PR! I will merge this, but for future reference, rather than true, I prefer a log error message, as @ChrisCarini did very beautifully here: https://github.com/jlumbroso/free-disk-space/pull/8#pullrequestreview-1580280900

ChrisCarini commented 1 year ago

I prefer a log error message, as @ChrisCarini did very beautifully here:

Thank you for the kind words, @jlumbroso ! 😃