search

jluttine / rofi-power-menu

Configurable power menu mode for Rofi and dmenu
MIT License
422 stars 53 forks source link

Fix obsolete icon codepoints #18

Closed emar10 closed 1 year ago

emar10 commented 1 year ago

With Nerd Fonts v2.3.0, some of the icons used here have been moved to different codepoints to avoid collision with other characters. The old codepoints are still usable at the moment, but will be removed entirely with Nerd Fonts v3 and depending on local font configuration may not work correctly now.

This replaces the old codepoints with their equivalents in the newly allocated space, users with a reasonably up to date patched font should notice no change.

See ryanoasis/nerd-fonts#365 for more details.

jluttine commented 1 year ago

Thanks! :+1:

I tested this PR and it seems the symbols of the new codepoints show up in different size than before.

Before:

image

After:

image

So, need to think how to fix that. :thinking: I can have a look probably next week.

emar10 commented 1 year ago

If you're using a monospace font variant that may be the issue. Icon sizing is pretty inconsistent in my experience, sadly. Here's what I get with the Symbols Only Nerd Font v2.3.3:

image

ghost commented 1 year ago

I'm getting the same inconsistent icon sizing using v3.0.0 of DejaVu Nerd Font. Fixing the sizing might be more involved, maybe a partial fix is preferable?

Also, i think it might be useful to use the actual icons in the code. This would make a change in the font visually obvious, should it occur again. I've done that in #20 before i saw this PR and closed mine. Opinions?

jluttine commented 1 year ago

Thanks! I merged the PR. I changed all the icons to use Material Design symbols so they look more consistent. Also, I added --symbols-font=... option to control a font only for the symbols. That way one can use --symbols-font="Symbols Nerd Font Mono" to get good looking symbols while having a different font for the text.