jlvaillant / intellicenter

Home Assistant Integration for Pentair Intellicenter
GNU General Public License v3.0
38 stars 13 forks source link

Deprecated attributes that will break 06.2022 #34

Open sellison2 opened 2 years ago

sellison2 commented 2 years ago

When Home Assistant starts up, it spits out a couple of messages in the log files:

Detected integration that accessed discovery_info['host'] instead of discovery_info.host; this will fail in version 2022.6. Please report issue to the custom component author for intellicenter using this method at custom_components/intellicenter/config_flow.py, line 60: host = discovery_info[CONF_HOST]

and:

Entity switch.lights (<class 'custom_components.intellicenter.switch.PoolCircuit'>) implements device_state_attributes. Please report it to the custom component author. Entity switch.water_feature (<class 'custom_components.intellicenter.switch.PoolCircuit'>) implements device_state_attributes. Please report it to the custom component author. Entity number.intellichlor_1_output (<class 'custom_components.intellicenter.number.PoolNumber'>) implements device_state_attributes. Please report it to the custom component author. Entity water_heater.pool (<class 'custom_components.intellicenter.water_heater.PoolWaterHeater'>) implements device_state_attributes. Please report it to the custom component author. Entity water_heater.spa (<class 'custom_components.intellicenter.water_heater.PoolWaterHeater'>) implements device_state_attributes. Please report it to the custom component author.

The second issue seems easy enough to fix, just a find/replace: https://community.home-assistant.io/t/warning-that-custom-component-is-using-device-state-attributes/376020

Looks like the first issue might also be a find and replace, but I couldn't find a quick Google result that said so. But more importantly, that first issue will apparently break this component in June.

jlvaillant commented 2 years ago

fixed in the incoming release

sellison2 commented 2 years ago

In version 1.1.0 the "device_state_attributes" part is fixed but not the "discovery_info['host']" issue.

jlvaillant commented 2 years ago

darn! I'll fix it ASAP. Thanks for pointing it out.

dwradcliffe commented 2 years ago

This is fixed now.