search

jlvaillant / intellicenter

Home Assistant Integration for Pentair Intellicenter
GNU General Public License v3.0
38 stars 13 forks source link

refactor to use modern attr patterns #55

Closed dwradcliffe closed 1 year ago

dwradcliffe commented 2 years ago

The current recommended way to set entity properties is with attributes named via convention: https://developers.home-assistant.io/docs/core/entity#entity-class-or-instance-attributes

This removes a lot of boilerplate code which keeps things simpler.

dwradcliffe commented 2 years ago

Also this will fix #52

roopesh commented 1 year ago

When will this be merged? The error indicates 2022.10 will break the integration, so I haven't upgraded yet.

dwradcliffe commented 1 year ago

I don’t really want to fork, but you can temporarily use my repo as it has the fix on main. You will need to remove and add my repo in HACS. The config should just work on boot.

roopesh commented 1 year ago

@dwradcliffe did you see this Error 400 report? https://github.com/jlvaillant/intellicenter/issues/58. I haven't installed from your repo yet. I also haven't upgrade to 2022.10 yet :)