search

jlvandenhout / contracts

MIT License
0 stars 0 forks source link

Publish utils package to pkg.go.dev #1

Closed salaheldinsoliman closed 1 day ago

salaheldinsoliman commented 2 weeks ago

This can really help in: https://github.com/iotaledger/iota-wiki/issues/1451 Where a lot of solidity contracts would be moved to the wasp repo, and tests added for each. I think it just needs a release to be published? @lucas-tortora @Dr-Electron WDYT?

lucas-tortora commented 2 weeks ago

Sounds good to me. Though, if we're going to publish it we should move it from a personal repo to an iotaledger repo

Ginowine commented 1 week ago

Hi @salaheldinsoliman, can you write a description for this package, what it does, and explain how we can use it in the move Solidity code to the Wasp repo tasks?

salaheldinsoliman commented 1 week ago

@Ginowine Hi Gino, I took @jlvandenhout 's work and tuned it a bit, as a lot of Solo utils was added recently. It would make more sense to use the example here: https://github.com/iotaledger/wasp/pull/3446/files As this makes use of what Solo currently offers.

Ginowine commented 1 week ago

Thanks. This new repo is clear and has fewer files.

salaheldinsoliman commented 1 week ago

yes, as most of @jlvandenhout 's util was later introduced in evmtest and wasp/util. @jlvandenhout Did you introduce util there yourself?

jlvandenhout commented 1 day ago

The utils in this repo are written by myself, partially based on what was, and probably more importantly what was not, available back then in the Wasp repo. With the recent changes to the Wasp repo, I guess it makes more sense to actually use what is in the Wasp repo and improve that where necessary. Feel free to close this if you agree.

salaheldinsoliman commented 1 day ago

Yup, closing this as the current util in wasp suffices what is needed for testing.