Some performance improvements

jm-david / emoji-mart-vue

One component to pick them all 👊🏼

https://jm-david.github.io/emoji-mart-vue

BSD 3-Clause "New" or "Revised" License

603 stars 82 forks source link

Some performance improvements #43

Open sololance opened 5 years ago

sololance commented 5 years ago

I have made some changes:

Remove styling usage from components (now you need to include css too!)
Reverted back #38, I have debugged it's better to use data directly without copying it multiple times?

Needs some testing if everything works perfectly for everyone then can be merged and compiled 😃. Performance should be at least %55 better 💯

Now when used with v-show opens instantly 🥇

More fixes for #9 , #29 , #34

andreasvirkus commented 5 years ago

@jm-david any updates on this? 🙏

LeonAlvarez commented 5 years ago

any upadte?

sololance commented 5 years ago

Well, almost 4 months passed, still not merged. Moved to this library https://github.com/kevinfaguiar/cool-emoji-picker

focux commented 5 years ago

I think I'm going to use your fork, I don't know why this don't get merge. @jm-david

abrantes01 commented 5 years ago

@jm-david Can we merge this PR ?

focux commented 5 years ago

If someone still need a improved, faster and better version of this package, I'm using this fork and it's way much better and fast, also It's published on npm.