return data from uncompress method to fix issue #48

jm-david / emoji-mart-vue

One component to pick them all 👊🏼

https://jm-david.github.io/emoji-mart-vue

BSD 3-Clause "New" or "Revised" License

603 stars 82 forks source link

return data from uncompress method to fix issue #48 #49

Open ikoolik opened 5 years ago

ikoolik commented 5 years ago

Issue https://github.com/jm-david/emoji-mart-vue/issues/48

In src/utils/emoji-index/nimble-emoji-index.js line 7, we assign the return value of the uncompress(data) call to the data variable. But the named function has no return value.

Because of this, the headless search is not functional. This quick fix should fix the issue.

4ver commented 5 years ago

Just to note, the return was removed recently in this pr https://github.com/jm-david/emoji-mart-vue/pull/42

ikoolik commented 5 years ago

I just found another PR #45 that also addresses the same issue but from a different angle (sorry, should've checked before creating my own)

Merging either #45 or #49 should fix the bug.

uniibu commented 5 years ago

Imo, PR #45 would be better approach than this as the data object is already mutated thus returning it will make no sense and will just add extra overhead.