search

jm / toml

Parse TOML. Like a bawss.
MIT License
151 stars 38 forks source link

Completes #37 #38

Closed squaresurf closed 9 years ago

squaresurf commented 9 years ago

This adds an interface for toml-test. That being said we do fail some of the tests and should probably look into fixing the failing tests.

parkr commented 9 years ago

Hey! Thanks for the pull request. Is something wrong with what I did in #35?

squaresurf commented 9 years ago

Sorry about that, I don't see anything wrong with #35. I had just checked the state of the tests with my git checkout and should have checked the PRs before creating this one.

One thing that #35 doesn't do is add an interface for testing the encoder. toml-test can be run with the -encoder=true switch and it will pass toml-test json to stdin for the script to convert to toml.

squaresurf commented 9 years ago

@parkr do you think you'll release this as a gem build anytime soon? I'm having to deploy a manual gem build with these fixes right now and would rather use your build off rubygems.

parkr commented 9 years ago

Yep!

squaresurf commented 9 years ago

Thank you :+1:

parkr commented 9 years ago

@squaresurf done! https://github.com/jm/toml/releases/tag/v0.1.2

squaresurf commented 9 years ago

Perfect. That helps a ton!

parkr commented 9 years ago

My pleasure – let me know if I can help out further!