search

jmacd / xdelta

open-source binary diff, delta/differential compression tools, VCDIFF/RFC 3284 delta compression
http://xdelta.org
1.1k stars 184 forks source link

regtest size #174

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
hi Josh,

we had build failures in Debian, here is a patch

a.

ps: the failure was here

https://buildd.debian.org/status/fetch.php?pkg=xdelta3&arch=i386&ver=3.0.7-dfsg-
1&stamp=1370799613

Original issue reported on code.google.com by mennu...@debian.org on 20 Feb 2014 at 11:41

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi,

We had the same issue here:

<code>
testing/regtest.cc:763:3: error: no matching function for call to 'max(xoff_t, 
size_t&)'
</code>

I cast'ed it, but the provided patch below is better.

Original comment by mcra...@gmail.com on 24 Feb 2014 at 9:42

GoogleCodeExporter commented 9 years ago 
I'll handle this one.

Original comment by josh.mac...@gmail.com on 3 Mar 2014 at 4:43

GoogleCodeExporter commented 9 years ago 
Please say which compiler gives you this trouble?
I can't take the patch as-is (should be "xoff_t" for consistency and 
portability, not uint64) but I'll roll it into the next release.

Original comment by josh.mac...@gmail.com on 9 Mar 2014 at 10:56

GoogleCodeExporter commented 9 years ago 
xoff_t is better. See my patch:

http://cgit.openembedded.org/meta-openembedded/commit/?id=92e26f5f69d8918c1e3789
0c07e2691febed4a2b

Original comment by mcra...@gmail.com on 20 Mar 2014 at 11:58

GoogleCodeExporter commented 9 years ago 
To be fixed in 3.0.9.

Original comment by josh.mac...@gmail.com on 15 Oct 2014 at 6:43