search

jmacdonald / amp

A complete text editor for your terminal.
https://amp.rs
Other
3.73k stars 105 forks source link

Typescript Syntax highlighting by default #119

Open bucktower opened 5 years ago

bucktower commented 5 years ago

It would be very helpful to include Typescript syntax highlighting by default, given its increasing interest over the past couple years. Here's a ts.sublime-syntax that should work fine for the mean time for everyone else.

jmacdonald commented 5 years ago

Thanks for this! We're currently leaning on the syntect crate for built-in syntaxes; I think it's worth owning that responsibility in Amp so that we can include these without having to upstream them into that crate. 🙂

jedahan commented 5 years ago

@bucktower mind adding that to the wiki as well? https://github.com/jmacdonald/amp/wiki

al3rez commented 5 years ago

@jmacdonald How about going like composition and not including specific syntax highlighting to keep amp fast and minimal?

pbgc commented 5 years ago

@jedahan I have some (like Coffeescript, Elixir, Dockerfile, Vue, etc) that I converted from .tmLanguage to .sublime-syntax but I don't know if I can share them on the wiki without attribution etc (I did not trace it and I don'r remember)

jedahan commented 5 years ago

@pbgc I think if you make a repository under your name with your conversions, and write a readme that says "I don't remember where I got all of these. If its yours, let me know and I will add attribution" are you comfortable with that?

jmacdonald commented 5 years ago

@azbshiri I think that'd violate Amp's philosophy of "batteries included"; major languages/formats should work out of the box. :slightly_smiling_face:

melMass commented 5 years ago

JSX should be included too !!