jmacdonald / amp

A complete text editor for your terminal.
https://amp.rs
Other
3.68k stars 105 forks source link

Allow specifying multiple line length guides. #210

Closed christoph-heiss closed 2 years ago

christoph-heiss commented 3 years ago

Hi!

Another small PR. This time implementing support for multiple line rulers. It's a small convenience feature without changing any current behaviour.

I've also been running this as part of my amp build for several months now.

[ One thought: Would it be worth to change line_length_guides() so to return a SmallVec with e.g. 4/6/8 elements instead of a full-blown Vec? ]

jmacdonald commented 2 years ago

This PR was automatically closed when the master branch was renamed to main. If you'd still like to have these changes reviewed and merged, please re-open this PR against the new main branch! 😁