Analysis Plan Feedback

[kescobo]

:exclamation: Don't merge this! :exclamation:

This PR is for feeback related to your analysis plan

Overall

• [x] 2 analysis plans
• [x] analysis_plan.md file, turned in on time #3

Plan 1

• [x] What analysis you plan to do
• [x] What functions you will use, including any new functions that you need to write
• [x] How you intend to display the results (eg what will you plot, or how will you summarize the results)

Plan 2

• [x] What analysis you plan to do
• [x] What functions you will use, including any new functions that you need to write
• [x] How you intend to display the results (eg what will you plot, or how will you summarize the results)

Rubrics

Excellent - full credit (5 pts)

• [ ] Two proposed analyses are clear and concise, and contain details including descriptions of functions needed, plots or other display items intended, and a clear roadmap for how to generate them
• [x] Markdown formatting is used effectively to organize into subsections, emphasize important points, and provide concise descriptions in lists
• [x] Assignment is submitted on time

Good - partial credit (4 pts)

• [ ] Two proposed analyses are clear and concise, but are missing some details of functions needed, plots or other display items intended
• [ ] Roadmap for generating intended analyses is clear, but missing some steps, or is complete but not entirely clear.
• [ ] Markdown formatting is used, but not as effectively as possible
• [ ] Assignment is submitted on time

Needs work - partial credit (3 or fewer points)

• [ ] Only 1 analysis proposed, or descriptions of analyses are incomplete
• [ ] Descriptions of functions needed and plots or other display items are unclear or incomplete
• [ ] Markdown formatting is used sparingly or not at all.
• [ ] Assignment is submitted late, or incorrectly.

[kescobo]

Looks great! I left a few comments / suggestion, but overall this looks like a good and doable set of analyses. The only thing missing is that you didn't describe how you're planning to display the results from analysis 2.

[jmaciuch]

Looks great! I left a few comments / suggestion, but overall this looks like a good and doable set of analyses. The only thing missing is that you didn't describe how you're planning to display the results from analysis 2.

Looks great! I left a few comments / suggestion, but overall this looks like a good and doable set of analyses. The only thing missing is that you didn't describe how you're planning to display the results from analysis 2.

I mentioned it in step 4: """ Create function that plots alignment score vs. length of time between collection dates.

• using scatter plot from Plots.jl.
• runs functions from step 2 and step 3 on each sequence pair from sliced dataset, outputs tuple (length (days), alignment score) for each pair """

Sorry if that wasn't clear. The plan is to make a function that uses the functions in step 2 & 3 to make tuples containing (length of time between collections, alignment score), and then use those as coordinate points on a scatter plot with time on x-axis and alignment score on y

[kescobo]

Quite right! Skimmed right over that it seems...

You might also consider boxplots (really, something like a candlestick plot) depending on the number of sequences you end up looking at and their dispersion, but starting with a scatter definitely makes sense :+1: